summaryrefslogtreecommitdiff
path: root/include/linux/sunrpc/debug.h
diff options
context:
space:
mode:
authorJeff Layton <jlayton@poochiereds.net>2015-03-20 15:15:14 -0400
committerTrond Myklebust <trond.myklebust@primarydata.com>2015-04-23 14:38:07 -0400
commit5d05e54af3cdbb13cf19c557ff2184781b91a22c (patch)
treef67bf3bdb8ad1fd4cc61ec8d0e23dfafdcbd3f8b /include/linux/sunrpc/debug.h
parentf830f7ddd9165c8bd69127458627f03df4b1a406 (diff)
nfs: fix high load average due to callback thread sleeping
Chuck pointed out a problem that crept in with commit 6ffa30d3f734 (nfs: don't call blocking operations while !TASK_RUNNING). Linux counts tasks in uninterruptible sleep against the load average, so this caused the system's load average to be pinned at at least 1 when there was a NFSv4.1+ mount active. Not a huge problem, but it's probably worth fixing before we get too many complaints about it. This patch converts the code back to use TASK_INTERRUPTIBLE sleep, simply has it flush any signals on each loop iteration. In practice no one should really be signalling this thread at all, so I think this is reasonably safe. With this change, there's also no need to game the hung task watchdog so we can also convert the schedule_timeout call back to a normal schedule. Cc: <stable@vger.kernel.org> Reported-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Jeff Layton <jeff.layton@primarydata.com> Tested-by: Chuck Lever <chuck.lever@oracle.com> Fixes: commit 6ffa30d3f734 (“nfs: don't call blocking . . .”) Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Diffstat (limited to 'include/linux/sunrpc/debug.h')
0 files changed, 0 insertions, 0 deletions