diff options
author | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2017-12-19 06:43:37 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2018-03-07 05:55:05 -0500 |
commit | 39ad07b7de82bff26118a69e680cda3d081392dc (patch) | |
tree | 4bbefdbe7e13e6008cc0f8092afedc652c5c6c16 /include/media | |
parent | 8239bac18a760249c800eb032acc3f66cba8df04 (diff) |
media: s5c73m3-core: fix logic on a timeout condition
As warned by smatch:
drivers/media/i2c/s5c73m3/s5c73m3-core.c:268 s5c73m3_check_status() error: uninitialized symbol 'status'.
if s5c73m3_check_status() is called too late, time_is_after_jiffies(end)
will return 0, causing the while to abort before reading status.
The current code will do the wrong thing here, as it will still
check if status != value. The right fix here is to change
the logic to ensure that it will always read the status.
Suggested-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'include/media')
0 files changed, 0 insertions, 0 deletions