summaryrefslogtreecommitdiff
path: root/include/net/codel.h
diff options
context:
space:
mode:
authorBoris Sukholitko <boris.sukholitko@broadcom.com>2021-06-01 15:30:50 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-07-14 16:53:27 +0200
commit9cc3eb8abe2335bb92cc5ca76aa3458e650181ac (patch)
tree085344c9268c4e3eeaba52f8d215bf6df3febf3f /include/net/codel.h
parent0b440951273a86c5da3bfbc3b06fdb42f0aa7057 (diff)
net/sched: act_vlan: Fix modify to allow 0
[ Upstream commit 9c5eee0afca09cbde6bd00f77876754aaa552970 ] Currently vlan modification action checks existence of vlan priority by comparing it to 0. Therefore it is impossible to modify existing vlan tag to have priority 0. For example, the following tc command will change the vlan id but will not affect vlan priority: tc filter add dev eth1 ingress matchall action vlan modify id 300 \ priority 0 pipe mirred egress redirect dev eth2 The incoming packet on eth1: ethertype 802.1Q (0x8100), vlan 200, p 4, ethertype IPv4 will be changed to: ethertype 802.1Q (0x8100), vlan 300, p 4, ethertype IPv4 although the user has intended to have p == 0. The fix is to add tcfv_push_prio_exists flag to struct tcf_vlan_params and rely on it when deciding to set the priority. Fixes: 45a497f2d149a4a8061c (net/sched: act_vlan: Introduce TCA_VLAN_ACT_MODIFY vlan action) Signed-off-by: Boris Sukholitko <boris.sukholitko@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'include/net/codel.h')
0 files changed, 0 insertions, 0 deletions