summaryrefslogtreecommitdiff
path: root/include/rdma
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2010-10-15 12:56:21 +0200
committerJens Axboe <jaxboe@fusionio.com>2010-10-15 12:56:21 +0200
commit47526903feb52f4c26a6350370bdf74e337fcdb1 (patch)
tree319aaf924a030ccbb680817128606defd33ac476 /include/rdma
parent93055c31045a2d5599ec613a0c6cdcefc481a460 (diff)
ubd: fix incorrect sector handling during request restart
Commit f81f2f7c (ubd: drop unnecessary rq->sector manipulation) dropped request->sector manipulation in preparation for global request handling cleanup; unfortunately, it incorrectly assumed that the updated sector wasn't being used. ubd tries to issue as many requests as possible to io_thread. When issuing fails due to memory pressure or other reasons, the device is put on the restart list and issuing stops. On IO completion, devices on the restart list are scanned and IO issuing is restarted. ubd issues IOs sg-by-sg and issuing can be stopped in the middle of a request, so each device on the restart queue needs to remember where to restart in its current request. ubd needs to keep track of the issue position itself because, * blk_rq_pos(req) is now updated by the block layer to keep track of _completion_ position. * Multiple io_req's for the current request may be in flight, so it's difficult to tell where blk_rq_pos(req) currently is. Add ubd->rq_pos to keep track of the issue position and use it to correctly restart io_req issue. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Richard Weinberger <richard@nod.at> Tested-by: Richard Weinberger <richard@nod.at> Tested-by: Chris Frey <cdfrey@foursquare.net> Cc: stable@kernel.org Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'include/rdma')
0 files changed, 0 insertions, 0 deletions