diff options
| author | Theodore Ts'o <tytso@mit.edu> | 2014-03-24 14:43:12 -0400 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2014-12-03 11:58:43 +0100 |
| commit | ec81c28104fd2198f076203be3d1bae5546e863f (patch) | |
| tree | a0c2a33ae915b3dcc57e55b501b2a8f7b7b9906c /include | |
| parent | 692f067fb661c39cc800ae7407ab655173ca2de2 (diff) | |
ext4: atomically set inode->i_flags in ext4_set_inode_flags()
commit 5f16f3225b06242a9ee876f07c1c9b6ed36a22b6 upstream.
Use cmpxchg() to atomically set i_flags instead of clearing out the
S_IMMUTABLE, S_APPEND, etc. flags and then setting them from the
EXT4_IMMUTABLE_FL, EXT4_APPEND_FL flags, since this opens up a race
where an immutable file has the immutable flag cleared for a brief
window of time.
js: there is no change for ext4. This patch defines merely
inode_set_flags for jffs in the next patch. I wonder why do we
have both inode_set_flags and set_mask_bits? Looks like an
improperly resolved merge conflict.
Reported-by: John Sullivan <jsrhbz@kanargh.force9.co.uk>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@kernel.org
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/fs.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/linux/fs.h b/include/linux/fs.h index 6535d5af027e..9cb726aa09fc 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2496,6 +2496,9 @@ static inline ssize_t blockdev_direct_IO(int rw, struct kiocb *iocb, void inode_dio_wait(struct inode *inode); void inode_dio_done(struct inode *inode); +extern void inode_set_flags(struct inode *inode, unsigned int flags, + unsigned int mask); + extern const struct file_operations generic_ro_fops; #define special_file(m) (S_ISCHR(m)||S_ISBLK(m)||S_ISFIFO(m)||S_ISSOCK(m)) |