diff options
| author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2022-02-25 11:22:23 +0200 |
|---|---|---|
| committer | Vladimir Oltean <vladimir.oltean@nxp.com> | 2022-05-04 15:24:58 +0200 |
| commit | 7ec5cbb138ec80dc77a9e297fa16ea71302996ae (patch) | |
| tree | 6a14f23343f662412cecf3a34f735dfb79bd29bd /include | |
| parent | 2e0c84e97f4674cd1416bee4221fe14508853c7d (diff) | |
net: dsa: pass extack to .port_bridge_join driver methods
As FDB isolation cannot be enforced between VLAN-aware bridges in lack
of hardware assistance like extra FID bits, it seems plausible that many
DSA switches cannot do it. Therefore, they need to reject configurations
with multiple VLAN-aware bridges from the two code paths that can
transition towards that state:
- joining a VLAN-aware bridge
- toggling VLAN awareness on an existing bridge
The .port_vlan_filtering method already propagates the netlink extack to
the driver, let's propagate it from .port_bridge_join too, to make sure
that the driver can use the same function for both.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 06b9cce42634a50f2840777a66553b02320db5ef)
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/net/dsa.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/include/net/dsa.h b/include/net/dsa.h index d96e2aa73eb3..4b0175232a1c 100644 --- a/include/net/dsa.h +++ b/include/net/dsa.h @@ -911,7 +911,8 @@ struct dsa_switch_ops { int (*set_ageing_time)(struct dsa_switch *ds, unsigned int msecs); int (*port_bridge_join)(struct dsa_switch *ds, int port, struct dsa_bridge bridge, - bool *tx_fwd_offload); + bool *tx_fwd_offload, + struct netlink_ext_ack *extack); void (*port_bridge_leave)(struct dsa_switch *ds, int port, struct dsa_bridge bridge); void (*port_stp_state_set)(struct dsa_switch *ds, int port, @@ -995,7 +996,8 @@ struct dsa_switch_ops { */ int (*crosschip_bridge_join)(struct dsa_switch *ds, int tree_index, int sw_index, int port, - struct dsa_bridge bridge); + struct dsa_bridge bridge, + struct netlink_ext_ack *extack); void (*crosschip_bridge_leave)(struct dsa_switch *ds, int tree_index, int sw_index, int port, struct dsa_bridge bridge); |