summaryrefslogtreecommitdiff
path: root/kernel/auditsc.c
diff options
context:
space:
mode:
authorRoland McGrath <roland@redhat.com>2008-06-23 20:41:12 -0700
committerRoland McGrath <roland@redhat.com>2008-07-23 17:43:36 -0700
commit15e8f348db372dec21229fda5d52ae6ee7e64666 (patch)
tree73afc044ef5b4e29a893e98afee2fe794938aeb3 /kernel/auditsc.c
parent20b7997e8abdf338dcc27fb4f1333c4973a7f113 (diff)
x86_64: remove bogus optimization in sysret_signal
This short-circuit path in sysret_signal looks wrong to me. AFAICT, in practice the branch is never taken--and if it were, it would go wrong. To wit, try loading a module whose init function does set_thread_flag(TIF_IRET), and see insmod crash (presumably with a wrong user stack pointer). This is because the FIXUP_TOP_OF_STACK work hasn't been done yet when we jump around the call to ptregscall_common and get to int_with_check--where it expects the user RSP,SS,CS and EFLAGS to have been stored by FIXUP_TOP_OF_STACK. I don't think it's normally possible to get to sysret_signal with no _TIF_DO_NOTIFY_MASK bits set anyway, so these two instructions are already superfluous. If it ever did happen, it is harmless to call do_notify_resume with nothing for it to do. Signed-off-by: Roland McGrath <roland@redhat.com>
Diffstat (limited to 'kernel/auditsc.c')
0 files changed, 0 insertions, 0 deletions