diff options
| author | Jason Wessel <jason.wessel@windriver.com> | 2012-03-29 06:17:17 -0500 |
|---|---|---|
| committer | Varun Wadekar <vwadekar@nvidia.com> | 2012-04-18 18:38:29 +0530 |
| commit | 0c0ac130ad743e575d756847db9a37e39b805a47 (patch) | |
| tree | 058f2c19d466c3834ea9763b26367e24a5d62d01 /kernel/debug | |
| parent | afa4eebebd05c718c9933632f4eaf055bdd07324 (diff) | |
kdb: Fix smatch warning on dbg_io_ops->is_console
The Smatch tool warned that the change from commit b8adde8dd
(kdb: Avoid using dbg_io_ops until it is initialized) should
add another null check later in the kdb_printf().
It is worth noting that the second use of dbg_io_ops->is_console
is protected by the KDB_PAGER state variable which would only
get set when kdb is fully active and initialized. If we
ever encounter changes or defects in the KDB_PAGER state
we do not want to crash the kernel in a kdb_printf/printk.
CC: Tim Bird <tim.bird@am.sony.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Diffstat (limited to 'kernel/debug')
| -rw-r--r-- | kernel/debug/kdb/kdb_io.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c index 3ba1f0422fe5..18a4cb33c52b 100644 --- a/kernel/debug/kdb/kdb_io.c +++ b/kernel/debug/kdb/kdb_io.c @@ -751,7 +751,7 @@ kdb_printit: kdb_input_flush(); c = console_drivers; - if (!dbg_io_ops->is_console) { + if (dbg_io_ops && !dbg_io_ops->is_console) { len = strlen(moreprompt); cp = moreprompt; while (len--) { |