diff options
author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2014-11-12 10:28:33 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-11-25 17:06:38 -0800 |
commit | 54178fe6b3443249ec2dcd6eec9f2c3ebcdc3142 (patch) | |
tree | ee6e61dcf95c3f8eac6edb1c01e380bdb1d9b5db /kernel/gcov/base.c | |
parent | 6b1f40cf4840820051d69646af0b6503878cb1bc (diff) |
tty: serial: 8250: omap: line is unsigned, don't check < 0
Dan Carpenter reported:
|drivers/tty/serial/8250/8250_omap.c:1025 omap8250_probe()
|warn: unsigned 'up.port.line' is never less than zero.
|1025 if (up.port.line < 0) {
I (wrongly) assumed that line is an int and compiler didn't complain nor
did sparse. Since of_alias_get_id() and pdev->id can get negative I
check for the error via ret variable.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel/gcov/base.c')
0 files changed, 0 insertions, 0 deletions