diff options
| author | Horia Geantă <horia.geanta@nxp.com> | 2017-07-07 16:57:06 +0300 |
|---|---|---|
| committer | Sasha Levin <alexander.levin@verizon.com> | 2017-07-31 13:37:55 -0400 |
| commit | 36feca8ce385643d131d99b53d01adb8cc0b0ebd (patch) | |
| tree | 3f5686c9581922e90d5a08c9452abf7f435040d5 /kernel/sched/core.c | |
| parent | f04dc46b10998384d1726da0aa319c075503fd53 (diff) | |
crypto: caam - fix signals handling
[ Upstream commit 7459e1d25ffefa2b1be799477fcc1f6c62f6cec7 ]
Driver does not properly handle the case when signals interrupt
wait_for_completion_interruptible():
-it does not check for return value
-completion structure is allocated on stack; in case a signal interrupts
the sleep, it will go out of scope, causing the worker thread
(caam_jr_dequeue) to fail when it accesses it
wait_for_completion_interruptible() is replaced with uninterruptable
wait_for_completion().
We choose to block all signals while waiting for I/O (device executing
the split key generation job descriptor) since the alternative - in
order to have a deterministic device state - would be to flush the job
ring (aborting *all* in-progress jobs).
Cc: <stable@vger.kernel.org>
Fixes: 045e36780f115 ("crypto: caam - ahash hmac support")
Fixes: 4c1ec1f930154 ("crypto: caam - refactor key_gen, sg")
Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Diffstat (limited to 'kernel/sched/core.c')
0 files changed, 0 insertions, 0 deletions