diff options
author | Oleg Nesterov <oleg@redhat.com> | 2012-11-21 18:01:43 +0100 |
---|---|---|
committer | Oleg Nesterov <oleg@redhat.com> | 2013-02-08 17:47:01 +0100 |
commit | f0744af7d0fde190674064c54e2ff60b34ac71fe (patch) | |
tree | 1fbe365e02f6d11c1a8837689578ef9b0874f0fa /kernel/trace/trace_probe.h | |
parent | bbc33d05930f870ea049eae5ed980f8b827d0813 (diff) |
uprobes: Kill the pointless inode/uc checks in register/unregister
register/unregister verifies that inode/uc != NULL. For what?
This really looks like "hide the potential problem", the caller
should pass the valid data.
register() also checks uc->next == NULL, probably to prevent the
double-register but the caller can do other stupid/wrong things.
If we do this check, then we should document that uc->next should
be cleared before register() and add BUG_ON().
Also add the small comment about the i_size_read() check.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Diffstat (limited to 'kernel/trace/trace_probe.h')
0 files changed, 0 insertions, 0 deletions