diff options
author | Brian Silverman <brian@peloton-tech.com> | 2015-02-18 16:23:56 -0800 |
---|---|---|
committer | Sasha Levin <sasha.levin@oracle.com> | 2015-04-24 17:13:43 -0400 |
commit | 42d921d36be6e0d315d1354921eaf0813544267c (patch) | |
tree | 9eb0a246ed10c6697d131ddb0dd4b115f189cbd3 /kernel | |
parent | a38edfb21325d2397dc08c76258682a8b7a51028 (diff) |
sched: Fix RLIMIT_RTTIME when PI-boosting to RT
[ Upstream commit 746db9443ea57fd9c059f62c4bfbf41cf224fe13 ]
When non-realtime tasks get priority-inheritance boosted to a realtime
scheduling class, RLIMIT_RTTIME starts to apply to them. However, the
counter used for checking this (the same one used for SCHED_RR
timeslices) was not getting reset. This meant that tasks running with a
non-realtime scheduling class which are repeatedly boosted to a realtime
one, but never block while they are running realtime, eventually hit the
timeout without ever running for a time over the limit. This patch
resets the realtime timeslice counter when un-PI-boosting from an RT to
a non-RT scheduling class.
I have some test code with two threads and a shared PTHREAD_PRIO_INHERIT
mutex which induces priority boosting and spins while boosted that gets
killed by a SIGXCPU on non-fixed kernels but doesn't with this patch
applied. It happens much faster with a CONFIG_PREEMPT_RT kernel, and
does happen eventually with PREEMPT_VOLUNTARY kernels.
Signed-off-by: Brian Silverman <brian@peloton-tech.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: austin@peloton-tech.com
Cc: <stable@vger.kernel.org>
Link: http://lkml.kernel.org/r/1424305436-6716-1-git-send-email-brian@peloton-tech.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/sched/core.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 9f5ed5e70eaa..b794bde3f5e1 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -3097,6 +3097,8 @@ void rt_mutex_setprio(struct task_struct *p, int prio) } else { if (dl_prio(oldprio)) p->dl.dl_boosted = 0; + if (rt_prio(oldprio)) + p->rt.timeout = 0; p->sched_class = &fair_sched_class; } |