diff options
author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2011-09-30 11:57:58 +0200 |
---|---|---|
committer | Clark Williams <williams@redhat.com> | 2012-04-10 16:37:26 -0500 |
commit | 9e679cf0ea7fb7983e9029e69ebd6fa5fffad86b (patch) | |
tree | 84a7453a800bdca07a7b55ff4867c8fb0b655bf2 /lib/debugobjects.c | |
parent | 08a9ea0f05ce0d929492c114a8ed8aa25b6c826f (diff) |
workqueue: Fix cpuhotplug trainwreck
The current workqueue code does crazy stuff on cpu unplug, it relies on
forced affine breakage, thereby violating per-cpu expectations. Worse,
it tries to re-attach to a cpu if the thing comes up again before all
previously queued works are finished. This breaks (admittedly bonkers)
cpu-hotplug use that relies on a down-up cycle to push all usage away.
Introduce a new WQ_NON_AFFINE flag that indicates a per-cpu workqueue
will not respect cpu affinity and use this to migrate all its pending
works to whatever cpu is doing cpu-down.
This also adds a warning for queue_on_cpu() users which warns when its
used on WQ_NON_AFFINE workqueues for the API implies you care about
what cpu things are ran on when such workqueues cannot guarantee this.
For the rest, simply flush all per-cpu works and don't mess about.
This also means that currently all workqueues that are manually
flushing things on cpu-down in order to provide the per-cpu guarantee
no longer need to do so.
In short, we tell the WQ what we want it to do, provide validation for
this and loose ~250 lines of code.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'lib/debugobjects.c')
0 files changed, 0 insertions, 0 deletions