diff options
| author | Andy Grover <agrover@redhat.com> | 2016-11-21 16:35:30 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-01-09 08:07:53 +0100 |
| commit | e321f384d8a58e546469cc8d3ca04257ef474d4c (patch) | |
| tree | a709d88454a91cec917c5160a0a8c7076980f61a /lib/klist.c | |
| parent | e5de1c724c060bb8a963aaed8e09e7d1a5f3ad1c (diff) | |
target/user: Fix use-after-free of tcmu_cmds if they are expired
commit d0905ca757bc40bd1ebc261a448a521b064777d7 upstream.
Don't free the cmd in tcmu_check_expired_cmd, it's still referenced by
an entry in our cmd_id->cmd idr. If userspace ever resumes processing,
tcmu_handle_completions() will use the now-invalid cmd pointer.
Instead, don't free cmd. It will be freed by tcmu_handle_completion() if
userspace ever recovers, or tcmu_free_device if not.
Reported-by: Bryant G Ly <bgly@us.ibm.com>
Tested-by: Bryant G Ly <bgly@us.ibm.com>
Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib/klist.c')
0 files changed, 0 insertions, 0 deletions