summaryrefslogtreecommitdiff
path: root/lib/string_helpers.c
diff options
context:
space:
mode:
authorJeff Layton <jlayton@redhat.com>2012-07-11 09:09:35 -0400
committerBen Hutchings <ben@decadent.org.uk>2012-07-25 04:11:26 +0100
commit8e1e19fe1940b5b438273e92036964b1230b6766 (patch)
treee2db7ada746dd0a95a33e21eebe9a040ecfe9297 /lib/string_helpers.c
parent1edae5d5207b5c11e734a465fd0d8618952f74b4 (diff)
cifs: on CONFIG_HIGHMEM machines, limit the rsize/wsize to the kmap space
commit 3ae629d98bd5ed77585a878566f04f310adbc591 upstream. We currently rely on being able to kmap all of the pages in an async read or write request. If you're on a machine that has CONFIG_HIGHMEM set then that kmap space is limited, sometimes to as low as 512 slots. With 512 slots, we can only support up to a 2M r/wsize, and that's assuming that we can get our greedy little hands on all of them. There are other users however, so it's possible we'll end up stuck with a size that large. Since we can't handle a rsize or wsize larger than that currently, cap those options at the number of kmap slots we have. We could consider capping it even lower, but we currently default to a max of 1M. Might as well allow those luddites on 32 bit arches enough rope to hang themselves. A more robust fix would be to teach the send and receive routines how to contend with an array of pages so we don't need to marshal up a kvec array at all. That's a fairly significant overhaul though, so we'll need this limit in place until that's ready. Reported-by: Jian Li <jiali@redhat.com> Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Steve French <smfrench@gmail.com> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'lib/string_helpers.c')
0 files changed, 0 insertions, 0 deletions