summaryrefslogtreecommitdiff
path: root/mm
diff options
context:
space:
mode:
authorMartin Kelly <martin@martingkelly.com>2018-10-28 20:18:53 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-12-05 19:42:41 +0100
commit06c2233ac246507e98022809ea4752dbfead9337 (patch)
treeccd875eb80b5337c3b01d59ed7aa62e106cc181c /mm
parent4a978cfe599fbe87128a951db062ebe0a5339741 (diff)
iio:st_magn: Fix enable device after trigger
commit fe5192ac81ad0d4dfe1395d11f393f0513c15f7f upstream. Currently, we enable the device before we enable the device trigger. At high frequencies, this can cause interrupts that don't yet have a poll function associated with them and are thus treated as spurious. At high frequencies with level interrupts, this can even cause an interrupt storm of repeated spurious interrupts (~100,000 on my Beagleboard with the LSM9DS1 magnetometer). If these repeat too much, the interrupt will get disabled and the device will stop functioning. To prevent these problems, enable the device prior to enabling the device trigger, and disable the divec prior to disabling the trigger. This means there's no window of time during which the device creates interrupts but we have no trigger to answer them. Fixes: 90efe055629 ("iio: st_sensors: harden interrupt handling") Signed-off-by: Martin Kelly <martin@martingkelly.com> Tested-by: Denis Ciocca <denis.ciocca@st.com> Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions