diff options
author | Jason Wang <jasowang@redhat.com> | 2013-07-18 10:55:16 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-07-18 13:04:25 -0700 |
commit | ece793fcfc417b3925844be88a6a6dc82ae8f7c6 (patch) | |
tree | 82348926544697293154d9870ce166c06fb6919f /net/8021q | |
parent | 885291761dba2bfe04df4c0f7bb75e4c920ab82e (diff) |
macvtap: do not zerocopy if iov needs more pages than MAX_SKB_FRAGS
We try to linearize part of the skb when the number of iov is greater than
MAX_SKB_FRAGS. This is not enough since each single vector may occupy more than
one pages, so zerocopy_sg_fromiovec() may still fail and may break the guest
network.
Solve this problem by calculate the pages needed for iov before trying to do
zerocopy and switch to use copy instead of zerocopy if it needs more than
MAX_SKB_FRAGS.
This is done through introducing a new helper to count the pages for iov, and
call uarg->callback() manually when switching from zerocopy to copy to notify
vhost.
We can do further optimization on top.
This bug were introduced from b92946e2919134ebe2a4083e4302236295ea2a73
(macvtap: zerocopy: validate vectors before building skb).
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/8021q')
0 files changed, 0 insertions, 0 deletions