diff options
| author | Alex Elder <elder@inktank.com> | 2012-09-21 17:59:58 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-11-26 11:38:43 -0800 |
| commit | 21e292e34c48c03fb6638c2d1295ca12dac97b03 (patch) | |
| tree | ba7de4f8fdac94c211b946544cd6a35cf9bd74e0 /net/ceph | |
| parent | 76cb69279f83889cf98fd9f16f5d50bcc2779442 (diff) | |
libceph: only kunmap kmapped pages
(cherry picked from commit 5ce765a540f34d1e2005e1210f49f67fdf11e997)
In write_partial_msg_pages(), pages need to be kmapped in order to
perform a CRC-32c calculation on them. As an artifact of the way
this code used to be structured, the kunmap() call was separated
from the kmap() call and both were done conditionally. But the
conditions under which the kmap() and kunmap() calls were made
differed, so there was a chance a kunmap() call would be done on a
page that had not been mapped.
The symptom of this was tripping a BUG() in kunmap_high() when
pkmap_count[nr] became 0.
Reported-by: Bryan K. Wright <bryan@virginia.edu>
Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/ceph')
| -rw-r--r-- | net/ceph/messenger.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c index 5f312510f49c..6577a9fc6ce7 100644 --- a/net/ceph/messenger.c +++ b/net/ceph/messenger.c @@ -1069,16 +1069,13 @@ static int write_partial_msg_pages(struct ceph_connection *con) BUG_ON(kaddr == NULL); base = kaddr + con->out_msg_pos.page_pos + bio_offset; crc = crc32c(crc, base, len); + kunmap(page); msg->footer.data_crc = cpu_to_le32(crc); con->out_msg_pos.did_page_crc = true; } ret = ceph_tcp_sendpage(con->sock, page, con->out_msg_pos.page_pos + bio_offset, len, 1); - - if (do_datacrc) - kunmap(page); - if (ret <= 0) goto out; |