diff options
author | Johannes Berg <johannes.berg@intel.com> | 2016-01-26 11:29:03 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-03-03 15:07:26 -0800 |
commit | 33bf18e4aa06f4b31eb21c1f77d4286f49dfc72e (patch) | |
tree | 7c217b3a3efdf8b2eb8d06f40020edc9c267f491 /net/mac80211/scan.c | |
parent | d024d46ec5203664fac872a20f7d75125db952da (diff) |
rfkill: fix rfkill_fop_read wait_event usage
commit 6736fde9672ff6717ac576e9bba2fd5f3dfec822 upstream.
The code within wait_event_interruptible() is called with
!TASK_RUNNING, so mustn't call any functions that can sleep,
like mutex_lock().
Since we re-check the list_empty() in a loop after the wait,
it's safe to simply use list_empty() without locking.
This bug has existed forever, but was only discovered now
because all userspace implementations, including the default
'rfkill' tool, use poll() or select() to get a readable fd
before attempting to read.
Fixes: c64fb01627e24 ("rfkill: create useful userspace interface")
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/mac80211/scan.c')
0 files changed, 0 insertions, 0 deletions