diff options
| author | Patrick McHardy <kaber@trash.net> | 2008-01-23 20:36:30 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-01-28 15:11:23 -0800 |
| commit | 53b2bf3f8a652c9c8e86831f94ae2c5767ea54d7 (patch) | |
| tree | eba61efed08a932766a32b0b6a60e766f8b44bcb /net/sched/act_simple.c | |
| parent | 6fa8c0144b770dac941cf2c15053b6e24f046c8a (diff) | |
[NET_SCHED]: Use nla_policy for attribute validation in actions
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_simple.c')
| -rw-r--r-- | net/sched/act_simple.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/net/sched/act_simple.c b/net/sched/act_simple.c index cedaadf18eb2..fbde461b716c 100644 --- a/net/sched/act_simple.c +++ b/net/sched/act_simple.c @@ -84,6 +84,10 @@ static int realloc_defdata(struct tcf_defact *d, u32 datalen, void *defdata) return alloc_defdata(d, datalen, defdata); } +static const struct nla_policy simple_policy[TCA_DEF_MAX + 1] = { + [TCA_DEF_PARMS] = { .len = sizeof(struct tc_defact) }, +}; + static int tcf_simp_init(struct nlattr *nla, struct nlattr *est, struct tc_action *a, int ovr, int bind) { @@ -102,8 +106,7 @@ static int tcf_simp_init(struct nlattr *nla, struct nlattr *est, if (err < 0) return err; - if (tb[TCA_DEF_PARMS] == NULL || - nla_len(tb[TCA_DEF_PARMS]) < sizeof(*parm)) + if (tb[TCA_DEF_PARMS] == NULL) return -EINVAL; parm = nla_data(tb[TCA_DEF_PARMS]); |