diff options
| author | David S. Miller <davem@davemloft.net> | 2010-09-12 11:56:44 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-09-12 11:56:44 -0700 |
| commit | a505b3b30fc69904f858822a2aa95990a4bf7958 (patch) | |
| tree | 4ea708f794d8cb91f77d42e32fce5324902cc274 /net/sched/sch_atm.c | |
| parent | 053d8f6622701f849fda2ca2c9ae596c13599ba9 (diff) | |
sch_atm: Fix potential NULL deref.
The list_head conversion unearther an unnecessary flow
check. Since flow is always NULL here we don't need to
see if a matching flow exists already.
Reported-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_atm.c')
| -rw-r--r-- | net/sched/sch_atm.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/net/sched/sch_atm.c b/net/sched/sch_atm.c index 340662789529..6318e1136b83 100644 --- a/net/sched/sch_atm.c +++ b/net/sched/sch_atm.c @@ -255,10 +255,6 @@ static int atm_tc_change(struct Qdisc *sch, u32 classid, u32 parent, error = -EINVAL; goto err_out; } - if (!list_empty(&flow->list)) { - error = -EEXIST; - goto err_out; - } } else { int i; unsigned long cl; |