summaryrefslogtreecommitdiff
path: root/net/wireless
diff options
context:
space:
mode:
authorEric Biggers <ebiggers@google.com>2019-06-10 13:02:19 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-07-10 09:55:35 +0200
commite4f18614c1a6b7bab3d25a1fe316a38c3787a386 (patch)
tree6c11bd33bb995fac7206ab310fbc5080ff3d0353 /net/wireless
parent68d1e285e934c50df37d807a8e7ae29397c055bc (diff)
cfg80211: fix memory leak of wiphy device name
commit 4f488fbca2a86cc7714a128952eead92cac279ab upstream. In wiphy_new_nm(), if an error occurs after dev_set_name() and device_initialize() have already been called, it's necessary to call put_device() (via wiphy_free()) to avoid a memory leak. Reported-by: syzbot+7fddca22578bc67c3fe4@syzkaller.appspotmail.com Fixes: 1f87f7d3a3b4 ("cfg80211: add rfkill support") Cc: stable@vger.kernel.org Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/wireless')
-rw-r--r--net/wireless/core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/wireless/core.c b/net/wireless/core.c
index 7fbf4dd07277..74554bdd9a5b 100644
--- a/net/wireless/core.c
+++ b/net/wireless/core.c
@@ -478,7 +478,7 @@ use_default_name:
&rdev->rfkill_ops, rdev);
if (!rdev->rfkill) {
- kfree(rdev);
+ wiphy_free(&rdev->wiphy);
return NULL;
}