diff options
| author | Dan Carpenter <error27@gmail.com> | 2010-09-10 01:56:16 +0000 |
|---|---|---|
| committer | Paul Gortmaker <paul.gortmaker@windriver.com> | 2011-01-06 18:07:59 -0500 |
| commit | 63b722fac15fc2f9e5846b64a484dd14b0c475c9 (patch) | |
| tree | 73875d14a7a23e3d46e2b55bd1f8e8a8505b9c81 /net | |
| parent | 18051b416cd5211d3be28821a0b2927cac54b9ba (diff) | |
net/llc: make opt unsigned in llc_ui_setsockopt()
commit 339db11b219f36cf7da61b390992d95bb6b7ba2e upstream.
The members of struct llc_sock are unsigned so if we pass a negative
value for "opt" it can cause a sign bug. Also it can cause an integer
overflow when we multiply "opt * HZ".
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Diffstat (limited to 'net')
| -rw-r--r-- | net/llc/af_llc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c index 2db6a9f75913..ad4296c852eb 100644 --- a/net/llc/af_llc.c +++ b/net/llc/af_llc.c @@ -1024,7 +1024,8 @@ static int llc_ui_setsockopt(struct socket *sock, int level, int optname, { struct sock *sk = sock->sk; struct llc_sock *llc = llc_sk(sk); - int rc = -EINVAL, opt; + unsigned int opt; + int rc = -EINVAL; lock_sock(sk); if (unlikely(level != SOL_LLC || optlen != sizeof(int))) |