summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorMichael Chan <mchan@broadcom.com>2013-09-18 01:50:39 -0700
committerDavid S. Miller <davem@davemloft.net>2013-09-18 12:24:32 -0400
commit48a30569732be782119960a47ca05417e7e07dab (patch)
treeca54f6013fa114b6d70e685be3d003d8aef0af53 /net
parentf78afb356303e5f78750321a63809ef5c2d13c0d (diff)
cnic: Fix crash in cnic_bnx2x_service_kcq()
commit 104a43edb264321a4d41850e98153b4fa8a9ef42 cnic: Use CHIP_NUM macros from bnx2x.h changed the code to use the bnx2x macro NO_FCOE() to determine if FCoE is supported or not. There is another place in cnic that is still using the old method to determine if FCoE is supported or not. The 2 methods may not yield the same result after the network interface is brought down and up. This will cause the crash as cnic_bnx2x_service_kcq() will access the uninitialized cp->kcq2. The fix is to consistently use the same macro CNIC_SUPPORTS_FCOE() which uses the bnx2x NO_FCOE() macro. As a follow-up, we can clean up the code to remove the old method as it is no longer needed. Signed-off-by: Michael Chan <mchan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions