diff options
author | Daniel Borkmann <dborkman@redhat.com> | 2014-01-06 00:57:54 +0100 |
---|---|---|
committer | Jiri Slaby <jslaby@suse.cz> | 2014-04-03 10:32:31 +0200 |
commit | f9c8e356e5c574cfa6ace53bb9956b4469fe606a (patch) | |
tree | d6ab311043ee01f60e6e4e006b3dff8049b16ba4 /scripts/gcc-x86_64-has-stack-protector.sh | |
parent | 9a110858ed2e494b8be683c6959113f73685eb1f (diff) |
netfilter: nf_conntrack_dccp: fix skb_header_pointer API usages
commit b22f5126a24b3b2f15448c3f2a254fc10cbc2b92 upstream.
Some occurences in the netfilter tree use skb_header_pointer() in
the following way ...
struct dccp_hdr _dh, *dh;
...
skb_header_pointer(skb, dataoff, sizeof(_dh), &dh);
... where dh itself is a pointer that is being passed as the copy
buffer. Instead, we need to use &_dh as the forth argument so that
we're copying the data into an actual buffer that sits on the stack.
Currently, we probably could overwrite memory on the stack (e.g.
with a possibly mal-formed DCCP packet), but unintentionally, as
we only want the buffer to be placed into _dh variable.
Fixes: 2bc780499aa3 ("[NETFILTER]: nf_conntrack: add DCCP protocol support")
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'scripts/gcc-x86_64-has-stack-protector.sh')
0 files changed, 0 insertions, 0 deletions