diff options
| author | Stephen Smalley <sds@tycho.nsa.gov> | 2008-09-22 15:41:19 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-08-26 16:40:12 -0700 |
| commit | 5a91177ccf6e429ec66b4f977fc92c105bd909a7 (patch) | |
| tree | 80f9b78bcb2a54e79900153b2b91ece3cff4600c /security/selinux | |
| parent | 5981f194641d4bcbff7e80adf393035b113f5022 (diff) | |
selinux: use default proc sid on symlinks
commit ea6b184f7d521a503ecab71feca6e4057562252b upstream.
As we are not concerned with fine-grained control over reading of
symlinks in proc, always use the default proc SID for all proc symlinks.
This should help avoid permission issues upon changes to the proc tree
as in the /proc/net -> /proc/self/net example.
This does not alter labeling of symlinks within /proc/pid directories.
ls -Zd /proc/net output before and after the patch should show the difference.
Signed-off-by: Stephen D. Smalley <sds@tycho.nsa.gov>
Signed-off-by: James Morris <jmorris@namei.org>
Cc: Florian Mickler <florian@mickler.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'security/selinux')
| -rw-r--r-- | security/selinux/hooks.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index e2d25da181fa..750cb17d50bd 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -1290,7 +1290,7 @@ static int inode_doinit_with_dentry(struct inode *inode, struct dentry *opt_dent /* Default to the fs superblock SID. */ isec->sid = sbsec->sid; - if (sbsec->proc) { + if (sbsec->proc && !S_ISLNK(inode->i_mode)) { struct proc_inode *proci = PROC_I(inode); if (proci->pde) { isec->sclass = inode_mode_to_security_class(inode->i_mode); |