diff options
| author | Jean Delvare <jdelvare@suse.de> | 2009-03-05 14:45:55 -0600 |
|---|---|---|
| committer | Chris Wright <chrisw@sous-sol.org> | 2009-04-27 10:36:59 -0700 |
| commit | 10b9c3cd8848919561d16570759c0146988cb8d5 (patch) | |
| tree | 9eeaedb03d34e6547fad903bab2187aaf13b92e4 /security | |
| parent | df76bd846a1c4a2264ad670c5b11aa2497edce19 (diff) | |
SCSI: libiscsi: fix iscsi pool error path
upstream commit: f474a37bc48667595b5653a983b635c95ed82a3b
Memory freeing in iscsi_pool_free() looks wrong to me. Either q->pool
can be NULL and this should be tested before dereferencing it, or it
can't be NULL and it shouldn't be tested at all. As far as I can see,
the only case where q->pool is NULL is on early error in
iscsi_pool_init(). One possible way to fix the bug is thus to not
call iscsi_pool_free() in this case (nothing needs to be freed anyway)
and then we can get rid of the q->pool check.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions