summaryrefslogtreecommitdiff
path: root/sound/drivers
diff options
context:
space:
mode:
authorFabrice Gasnier <fabrice.gasnier@foss.st.com>2021-03-03 18:49:49 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-04-14 08:24:09 +0200
commit8732c2df9d15f59b08db28503ca16fec01969b05 (patch)
treed6490bece3ff2412d0a93236ccd6e2a4cbda473d /sound/drivers
parenta49e5ea5e0450a3feb1aaae2554dcbc3d20eee38 (diff)
counter: stm32-timer-cnt: fix ceiling miss-alignment with reload register
commit b14d72ac731753708a7c1a6b3657b9312b6f0042 upstream Ceiling value may be miss-aligned with what's actually configured into the ARR register. This is seen after probe as currently the ARR value is zero, whereas ceiling value is set to the maximum. So: - reading ceiling reports zero - in case the counter gets enabled without any prior configuration, it won't count. - in case the function gets set by the user 1st, (priv->ceiling) is used. Fix it by getting rid of the cached "priv->ceiling" variable. Rather use the ARR register value directly by using regmap read or write when needed. There should be no drawback on performance as priv->ceiling isn't used in performance critical path. There's also no point in writing ARR while setting function (sms), so it can be safely removed. Fixes: ad29937e206f ("counter: Add STM32 Timer quadrature encoder") Suggested-by: William Breathitt Gray <vilhelm.gray@gmail.com> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com> Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com> Cc: <Stable@vger.kernel.org> Link: https://lore.kernel.org/r/1614793789-10346-1-git-send-email-fabrice.gasnier@foss.st.com Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> [sudip: adjuct context] Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound/drivers')
0 files changed, 0 insertions, 0 deletions