diff options
| author | Colin Ian King <colin.king@canonical.com> | 2019-11-22 13:13:54 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-01-09 10:17:56 +0100 |
| commit | d7867fbbd4d6dccf94aee75dd1281bd95ec46863 (patch) | |
| tree | cd99c1e06de4a21849704b2577a0e1c0fc9592de /sound/firewire | |
| parent | bc5e8a8a58be3e7414fb5abdbe49d731cbd26f2f (diff) | |
ALSA: cs4236: fix error return comparison of an unsigned integer
commit d60229d84846a8399257006af9c5444599f64361 upstream.
The return from pnp_irq is an unsigned integer type resource_size_t
and hence the error check for a positive non-error code is always
going to be true. A check for a non-failure return from pnp_irq
should in fact be for (resource_size_t)-1 rather than >= 0.
Addresses-Coverity: ("Unsigned compared against 0")
Fixes: a9824c868a2c ("[ALSA] Add CS4232 PnP BIOS support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20191122131354.58042-1-colin.king@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound/firewire')
0 files changed, 0 insertions, 0 deletions