summaryrefslogtreecommitdiff
path: root/sound/oss/mpu401.c
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2017-06-28 12:02:02 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-07-05 14:37:15 +0200
commit11327be3570e4640bf9c19e60b724f9fbb21eeb6 (patch)
treeb32cc3a64d8a23a71d481ef31696826d56125ff7 /sound/oss/mpu401.c
parentdb60a2ec9acc938c2427cbba367f20f1b0505267 (diff)
ALSA: hda - Fix endless loop of codec configure
commit d94815f917da770d42c377786dc428f542e38f71 upstream. azx_codec_configure() loops over the codecs found on the given controller via a linked list. The code used to work in the past, but in the current version, this may lead to an endless loop when a codec binding returns an error. The culprit is that the snd_hda_codec_configure() unregisters the device upon error, and this eventually deletes the given codec object from the bus. Since the list is initialized via list_del_init(), the next object points to the same device itself. This behavior change was introduced at splitting the HD-audio code code, and forgotten to adapt it here. For fixing this bug, just use a *_safe() version of list iteration. Fixes: d068ebc25e6e ("ALSA: hda - Move some codes up to hdac_bus struct") Reported-by: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound/oss/mpu401.c')
0 files changed, 0 insertions, 0 deletions