diff options
| author | Namhyung Kim <namhyung@kernel.org> | 2016-12-06 12:40:05 +0900 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-12-07 12:00:34 -0300 |
| commit | b336352b417edd8c058c9e09d136728b6e2ff56d (patch) | |
| tree | 8fabbd3039798fc3e1ddabd3f8f48c23a1f1ba96 /tools/perf/builtin-sched.c | |
| parent | 5d92d96a947a5d0d83710d11750bb29a0c1b985d (diff) | |
perf sched timehist: Cleanup idle_max_cpu handling
It treats the idle_max_cpu little bit confusingly IMHO. Let's make it
more straight forward.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: David Ahern <dsahern@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20161206034010.6499-6-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-sched.c')
| -rw-r--r-- | tools/perf/builtin-sched.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c index c8b3e6c330c3..1a3f1be93372 100644 --- a/tools/perf/builtin-sched.c +++ b/tools/perf/builtin-sched.c @@ -2010,7 +2010,7 @@ static int init_idle_threads(int ncpu) if (!idle_threads) return -ENOMEM; - idle_max_cpu = ncpu - 1; + idle_max_cpu = ncpu; /* allocate the actual thread struct if needed */ for (i = 0; i < ncpu; ++i) { @@ -2031,7 +2031,7 @@ static void free_idle_threads(void) if (idle_threads == NULL) return; - for (i = 0; i <= idle_max_cpu; ++i) { + for (i = 0; i < idle_max_cpu; ++i) { if ((idle_threads[i])) thread__delete(idle_threads[i]); } @@ -2054,8 +2054,7 @@ static struct thread *get_idle_thread(int cpu) return NULL; idle_threads = (struct thread **) p; - i = idle_max_cpu ? idle_max_cpu + 1 : 0; - for (; i < j; ++i) + for (i = idle_max_cpu; i < j; ++i) idle_threads[i] = NULL; idle_max_cpu = j; @@ -2495,7 +2494,7 @@ static void timehist_print_summary(struct perf_sched *sched, return; printf("\nIdle stats:\n"); - for (i = 0; i <= idle_max_cpu; ++i) { + for (i = 0; i < idle_max_cpu; ++i) { t = idle_threads[i]; if (!t) continue; |