diff options
author | Matt Fleming <matt.fleming@intel.com> | 2012-02-28 13:37:24 +0000 |
---|---|---|
committer | H. Peter Anvin <hpa@zytor.com> | 2012-02-28 10:23:02 -0800 |
commit | 92f42c50f227ad228f815a8f4eec872524dae3a5 (patch) | |
tree | f8fee9407ef1614ee81d27b1c4ec0efe8b41cb48 /tools/usb | |
parent | d40f833630a1299fd377408dc8d8fac370d621b0 (diff) |
x86, efi: Fix endian issues and unaligned accesses
We may need to convert the endianness of the data we read from/write
to 'buf', so let's use {get,put}_unaligned_le32() to do that. Failure
to do so can result in accessing invalid memory, leading to a
segfault. Stephen Rothwell noticed this bug while cross-building an
x86_64 allmodconfig kernel on PowerPC.
We need to read from and write to 'buf' a byte at a time otherwise
it's possible we'll perform an unaligned access, which can lead to bus
errors when cross-building an x86 kernel on risc architectures.
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Nick Bowler <nbowler@elliptictech.com>
Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Link: http://lkml.kernel.org/r/1330436245-24875-6-git-send-email-matt@console-pimps.org
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Diffstat (limited to 'tools/usb')
0 files changed, 0 insertions, 0 deletions