summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorMichael Witten <mfwitten@gmail.com>2011-04-09 01:12:56 +0000
committerArnaldo Carvalho de Melo <acme@redhat.com>2011-04-19 08:18:36 -0300
commit3643b133f2cb8023e8cedcbef43215a99d7df561 (patch)
tree9f398308ee4f51801c2fdee40ec7ffd65f6f1642 /tools
parentaeafcbaf4fcfeb74aeed65609ea5ead48dfc09f8 (diff)
perf tools: Makefile: Clean up `python/perf.so' rule
There is no need for a subshell or an explicit `export'; as per the POSIX Shell Command Language specification: http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_01 http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_10_02 It is only necessary to include the environment variable assignment just before the command to be run. Also, it is better to use single-quotes, because GNU make might expand `$(BASIC_CFLAGS)' into something that the shell could interpret within double-quotes. Acked-by: Raghavendra D Prabhu <rprabhu@wnohang.net> Link: http://lkml.kernel.org/n/tip-58n38o02ocuzrm9qh096hsf5@git.kernel.org Signed-off-by: Michael Witten <mfwitten@gmail.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/perf/Makefile10
1 files changed, 4 insertions, 6 deletions
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 207dee5c5b16..aaf4dd3fd803 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -165,12 +165,10 @@ grep-libs = $(filter -l%,$(1))
strip-libs = $(filter-out -l%,$(1))
$(OUTPUT)python/perf.so: $(PYRF_OBJS)
- $(QUIET_GEN)( \
- export CFLAGS="$(BASIC_CFLAGS)"; \
- python util/setup.py --quiet build_ext --build-lib='$(OUTPUT)python' \
- --build-temp='$(OUTPUT)python/temp' \
- )
-
+ $(QUIET_GEN)CFLAGS='$(BASIC_CFLAGS)' python util/setup.py \
+ --quiet build_ext \
+ --build-lib='$(OUTPUT)python' \
+ --build-temp='$(OUTPUT)python/temp'
#
# No Perl scripts right now:
#