summaryrefslogtreecommitdiff
path: root/usr
diff options
context:
space:
mode:
authordingtianhong <dingtianhong@huawei.com>2013-12-13 17:29:19 +0800
committerDavid S. Miller <davem@davemloft.net>2013-12-18 16:52:25 -0500
commit71a06c59d19a57c8dd2972ebee88030f5b0c700e (patch)
treecd55e18def09e35b41e63dd8429beab6dc945dc3 /usr
parent35eecf052250f663f07a4cded7d3503fd1b50729 (diff)
bonding: protect port for bond_3ad_adapter_speed_changed()
Jay Vosburgh said that the bond_3ad_adapter_speed_changed is called with RTNL only, and the function will modify the port's information with no further locking, it will not mutex against bond state machine and incoming LACPDU which do not hold RTNL, So I add __get_state_machine_lock to protect the port. But it is not a critical bug, it exist since day one, and till now it has never been hit and reported, because changes to speed is very rare, and will not occur critical problem. The comment in the function is very old, cleanup it. Suggested-by: Jay Vosburgh <fubar@us.ibm.com> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'usr')
0 files changed, 0 insertions, 0 deletions