diff options
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/ctree.c | 10 | ||||
| -rw-r--r-- | fs/btrfs/disk-io.c | 4 | ||||
| -rw-r--r-- | fs/btrfs/extent-tree.c | 4 | ||||
| -rw-r--r-- | fs/btrfs/locking.c | 6 | ||||
| -rw-r--r-- | fs/btrfs/locking.h | 2 | ||||
| -rw-r--r-- | fs/devpts/inode.c | 5 | 
6 files changed, 13 insertions, 18 deletions
| diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index 42491d728e99..37f31b5529aa 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -277,7 +277,7 @@ static noinline int __btrfs_cow_block(struct btrfs_trans_handle *trans,  	if (*cow_ret == buf)  		unlock_orig = 1; -	WARN_ON(!btrfs_tree_locked(buf)); +	btrfs_assert_tree_locked(buf);  	if (parent)  		parent_start = parent->start; @@ -2365,7 +2365,7 @@ static int push_leaf_right(struct btrfs_trans_handle *trans, struct btrfs_root  	if (slot >= btrfs_header_nritems(upper) - 1)  		return 1; -	WARN_ON(!btrfs_tree_locked(path->nodes[1])); +	btrfs_assert_tree_locked(path->nodes[1]);  	right = read_node_slot(root, upper, slot + 1);  	btrfs_tree_lock(right); @@ -2562,7 +2562,7 @@ static int push_leaf_left(struct btrfs_trans_handle *trans, struct btrfs_root  	if (right_nritems == 0)  		return 1; -	WARN_ON(!btrfs_tree_locked(path->nodes[1])); +	btrfs_assert_tree_locked(path->nodes[1]);  	left = read_node_slot(root, path->nodes[1], slot - 1);  	btrfs_tree_lock(left); @@ -4101,7 +4101,7 @@ int btrfs_next_leaf(struct btrfs_root *root, struct btrfs_path *path)  		next = read_node_slot(root, c, slot);  		if (!path->skip_locking) { -			WARN_ON(!btrfs_tree_locked(c)); +			btrfs_assert_tree_locked(c);  			btrfs_tree_lock(next);  			btrfs_set_lock_blocking(next);  		} @@ -4126,7 +4126,7 @@ int btrfs_next_leaf(struct btrfs_root *root, struct btrfs_path *path)  			reada_for_search(root, path, level, slot, 0);  		next = read_node_slot(root, next, 0);  		if (!path->skip_locking) { -			WARN_ON(!btrfs_tree_locked(path->nodes[level])); +			btrfs_assert_tree_locked(path->nodes[level]);  			btrfs_tree_lock(next);  			btrfs_set_lock_blocking(next);  		} diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index adda739a0215..3e18175248e0 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -857,7 +857,7 @@ int clean_tree_block(struct btrfs_trans_handle *trans, struct btrfs_root *root,  	struct inode *btree_inode = root->fs_info->btree_inode;  	if (btrfs_header_generation(buf) ==  	    root->fs_info->running_transaction->transid) { -		WARN_ON(!btrfs_tree_locked(buf)); +		btrfs_assert_tree_locked(buf);  		/* ugh, clear_extent_buffer_dirty can be expensive */  		btrfs_set_lock_blocking(buf); @@ -2361,7 +2361,7 @@ void btrfs_mark_buffer_dirty(struct extent_buffer *buf)  	btrfs_set_lock_blocking(buf); -	WARN_ON(!btrfs_tree_locked(buf)); +	btrfs_assert_tree_locked(buf);  	if (transid != root->fs_info->generation) {  		printk(KERN_CRIT "btrfs transid mismatch buffer %llu, "  		       "found %llu running %llu\n", diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 6b5966aacf44..9abf81f71c46 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -4418,13 +4418,13 @@ int btrfs_drop_subtree(struct btrfs_trans_handle *trans,  	path = btrfs_alloc_path();  	BUG_ON(!path); -	BUG_ON(!btrfs_tree_locked(parent)); +	btrfs_assert_tree_locked(parent);  	parent_level = btrfs_header_level(parent);  	extent_buffer_get(parent);  	path->nodes[parent_level] = parent;  	path->slots[parent_level] = btrfs_header_nritems(parent); -	BUG_ON(!btrfs_tree_locked(node)); +	btrfs_assert_tree_locked(node);  	level = btrfs_header_level(node);  	extent_buffer_get(node);  	path->nodes[level] = node; diff --git a/fs/btrfs/locking.c b/fs/btrfs/locking.c index 85506c4a3af7..47b0a88c12a2 100644 --- a/fs/btrfs/locking.c +++ b/fs/btrfs/locking.c @@ -220,8 +220,8 @@ int btrfs_tree_unlock(struct extent_buffer *eb)  	return 0;  } -int btrfs_tree_locked(struct extent_buffer *eb) +void btrfs_assert_tree_locked(struct extent_buffer *eb)  { -	return test_bit(EXTENT_BUFFER_BLOCKING, &eb->bflags) || -			spin_is_locked(&eb->lock); +	if (!test_bit(EXTENT_BUFFER_BLOCKING, &eb->bflags)) +		assert_spin_locked(&eb->lock);  } diff --git a/fs/btrfs/locking.h b/fs/btrfs/locking.h index 6bb0afbff928..6c4ce457168c 100644 --- a/fs/btrfs/locking.h +++ b/fs/btrfs/locking.h @@ -21,11 +21,11 @@  int btrfs_tree_lock(struct extent_buffer *eb);  int btrfs_tree_unlock(struct extent_buffer *eb); -int btrfs_tree_locked(struct extent_buffer *eb);  int btrfs_try_tree_lock(struct extent_buffer *eb);  int btrfs_try_spin_lock(struct extent_buffer *eb);  void btrfs_set_lock_blocking(struct extent_buffer *eb);  void btrfs_clear_lock_blocking(struct extent_buffer *eb); +void btrfs_assert_tree_locked(struct extent_buffer *eb);  #endif diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c index 5f3231b9633f..bff4052b05e7 100644 --- a/fs/devpts/inode.c +++ b/fs/devpts/inode.c @@ -198,9 +198,6 @@ static int mknod_ptmx(struct super_block *sb)  	fsi->ptmx_dentry = dentry;  	rc = 0; - -	printk(KERN_DEBUG "Created ptmx node in devpts ino %lu\n", -			inode->i_ino);  out:  	mutex_unlock(&root->d_inode->i_mutex);  	return rc; @@ -369,8 +366,6 @@ static int new_pts_mount(struct file_system_type *fs_type, int flags,  	struct pts_fs_info *fsi;  	struct pts_mount_opts *opts; -	printk(KERN_NOTICE "devpts: newinstance mount\n"); -  	err = get_sb_nodev(fs_type, flags, data, devpts_fill_super, mnt);  	if (err)  		return err; | 
