summaryrefslogtreecommitdiff
path: root/drivers/staging/vt6655
AgeCommit message (Collapse)Author
2014-10-02staging: vt6655: Fixed C99 // comment errors in wpactl.cEsra Altintas
The following patch fixes the checkpatch.pl warning: ERROR: do not use C99 // comments Signed-off-by: Esra Altintas <es.altintas@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: vt6655: Merge three lines into oneTapasweni Pathak
This patch merges three lines into one, removing unecessary if check. Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com> Reviewed-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: vt6655: Type conversion was made.Gulsah Kose
This patch fixes this sparse warning: drivers/staging/vt6655/device_main.c:385:40: warning: mixing different enum types drivers/staging/vt6655/device_main.c:385:40: int enum _VIA_BB_TYPE versus drivers/staging/vt6655/device_main.c:385:40: int enum _VIA_PKT_TYPE Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28Staging: vt6655: Add require space before that '('Aybuke Ozdemir
This patch fixes checkpatch.pl error in file device_main.c ERROR: space required before the open parenthesis '(' Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28Staging: vt6655: Add require space after that ','Aybuke Ozdemir
This patch fixes checkpatch.pl error in file device_main.c ERROR: space required after that ';' (ctx:VxV) Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-23staging: vt6655: device_get_options remove unused variable devnameMalcolm Priestley
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-23staging: vt6655: pr_err remove string to net device nameMalcolm Priestley
Just print driver name with dev_err removing the string formatting. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-23staging: vt6655: shift open brace '{' to previous lineTapasweni Pathak
This patch fixes checkpatch.pl error in baseband.c file ERROR : that open brace { should be on the previous line Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-23staging: vt6655: remove unnecessary else after returnTapasweni Pathak
This patch fixes checkpatch.pl warning in aes_ccmp.c file WARNING : else is not generally useful after a break or return Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-23Staging: vt6655: Fix C99 style commenting.Aybuke Ozdemir
This patch fixes these error messages found by checkpatch.pl: ERROR: do not use C99 // comments Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-22Merge 3.17-rc6 into staging-next.Greg Kroah-Hartman
We want the fixes in there, and it resolves a merge issue with drivers/iio/accel/bma180.c Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-19Staging: vt6655: Break 80 character long line to remove checkpatch errorRajbinder Brar
This removes checkpatch.pl warning WARNING: line over 80 characters Signed-off-by: Rajbinder Brar <brar.rajbinder@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-19Staging: vt6655: Fix C99 style commenting.Aybuke Ozdemir
This patch fixes these error messages found by checkpatch.pl: ERROR: do not use C99 // comments Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-19staging: vt6655: buffer overflow in ioctlDan Carpenter
->u.generic_elem.len is a user controlled number between 0-255. We should limit it to avoid memory corruption. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: vt6655: Remove unnecessary condition around includeTobias Klauser
ethtool (and SIOCETHTOOL in particular) is part of Linux since the pre-git era, it thus makes no sense no sense to make the include of linux/ethtool.h conditional. Also remove the unused define DEVICE_ETHTOOL_IOCTL_SUPPORT. Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: vt6655: Use net_device_stats from struct net_deviceTobias Klauser
Instead of using an own copy of struct net_device_stats in struct vnt_private, use stats from struct net_device. Also remove the thus unnecessary device_get_stats(), as it would now just return netdev->stats, which is the default in dev_get_stats(). Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: vt6655: Remove unused member from struct vnt_privateTobias Klauser
The pci_state member of struct vnt_private is used nowhere in the code, so remove it. Supposedly it was used to save the PCI configuration space which is now done using pci_save_state(). Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-08staging: vt6655: device_free_info() warn: variable dereferenced before checkMalcolm Priestley
pDevice is never NULL when this function is called remove the check. This fixes smatch warning drivers/staging/vt6655/device_main.c:1023 device_free_info() warn: variable dereferenced before check 'pDevice' (see line 1021) Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: kbuild@01.org Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: Replace typedef enum _CARD_OP_MODE eOPMode with enum ↵Malcolm Priestley
nl80211_iftype op_mode. Using the nl80211 header. Using enum changes OP_MODE_ADHOC -> NL80211_IFTYPE_ADHOC OP_MODE_AP -> NL80211_IFTYPE_AP OP_MODE_INFRASTRUCTURE -> NL80211_IFTYPE_STATION OP_MODE_UNKNOWN -> NL80211_IFTYPE_UNSPECIFIED Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: s_uGetRTSCTSDuration always return __le16Malcolm Priestley
This function should always return __le16, move all endian correction to here. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30stgaing: vt6655: remove unused variable wCTSDurationMalcolm Priestley
wCTSDuration is always set to 0. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: replace typedef struct tagSCTS_FB with struct vnt_cts_fbMalcolm Priestley
Replacing members b, wDuration_ba, wReserved, wCTSDuration_ba_f0, wCTSDuration_ba_f1, data and reserved2. With b, duration_ba, reserved, cts_duration_ba_f0, cts_duration_ba_f1, data and reserved2 unsigned short is replaced with u16 or __le16 where necessary. cast void pointer to pvCTS Creating the new structure in rxtx.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: replace typedef struct tagSCTS with struct vnt_ctsMalcolm Priestley
Replacing members b, wDuration_ba, wReserved, data and reserved2 with b, duration_ba, reserved, data and reserved2 unsigned short is replaced with u16 or __le16 where necessary. cast void pointer to pvCTS Creating the new structure in rxtx.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: replace typedef struct tagSRTS_a_FB with struct vnt_rts_a_fbMalcolm Priestley
Replacing members a, wDuration, wReserved, wRTSDuration_f0, wRTSDuration_f1 and data with a, duration, reserved, rts_duration_f0, rts_duration_f1 and data unsigned short is replaced with u16 or __le16 where necessary. cast void pointer to pvRTS Creating the new structure in rxtx.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: replace typedef struct tagSRTS_ab with struct vnt_rts_abMalcolm Priestley
Replacing members ab, wDuration, wReserved and data with ab, duration, reserved and data replacing unsigned short with u16 and __le16 where necessary. pvRTS is void pointer. Creating the new structure in rxtx.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: replace typedef struct tagSRTS_g_FB with struct vnt_rts_g_fbMalcolm Priestley
Replacing members b, a, wDuration_ba, wDuration_aa, wDuration_bb, wReserved, wRTSDuration_ba_f0, wRTSDuration_aa_f0, wRTSDuration_ba_f1, wRTSDuration_aa_f1 and data with b, a, duration_ba, duration_aa, duration_bb, wReserved, rts_duration_ba_f0, rts_duration_aa_f0, rts_duration_ba_f1, rts_duration_aa_f1 and data replacing unsigned short with u16 or __le16 where endian correction is necessary. Creating the new structure in rxtx.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: replace typedef struct tagSRTS_g with struct vnt_rts_gMalcolm Priestley
Replacing members b, a, wDuration_ba, wDuration_aa, wDuration_bb, wReserved and data with b, a,duration_ba, duration_aa, duration_bb, reserved and data replacing unsigned short with u16 or __le16 where endian correction is necessary. Creating the new structure in rxtx.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: Replace typedef struct tagSCTSData with ieee80211_cts dataMalcolm Priestley
ieee80211_cts data needs extra padding with reserved2 set to 0 use IEEE80211_FTYPE_CTL | IEEE80211_STYPE_CTS to set frame_control Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: Replace typedef struct tagSRTSData with ieee80211_rts dataMalcolm Priestley
Replacing SRTSData Data with struct ieee80211_rts data Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: Fix *Duration s_uFillDataHead to return to __le16Malcolm Priestley
All callers should be __le16. Fix vGenerateMACHeader duration to __le16 and reverse the endian conversion. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: replace -typedef struct tagSTxDataHead_a_FB with struct ↵Malcolm Priestley
vnt_tx_datahead_a_fb Replace members a, wDuration, wTimeStampOff, wDuration_f0, and wDuration_f1; with a, duration, time_stamp_off, duration_f0, duration_f1 All unsigned short members should be __le16 Creating the new structure in rxtx.h. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: replace typedef struct tagSTxDataHead_ab with struct ↵Malcolm Priestley
vnt_tx_datahead_ab Replacing members ab, wDuration and wTimeStampOff with ab, duration and time_stamp_off All unsigned short should be __le16 Structure is moved to rxtx.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: replace typedef struct tagSTxDataHead_g_FB with struct ↵Malcolm Priestley
vnt_tx_datahead_g_fb Replacing members b, a, wDuration_b, wDuration_a, wDuration_a_f0, wDuration_a_f1, wTimeStampOff_b and wTimeStampOff_a with b, a, duration_b, duration_a, duration_a_f0, duration_a_f1, time_stamp_off_b and time_stamp_off_a All unsigned short need to be __le16 type. Creating the new structure in rxtx.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: replace typedef struct tagSTxDataHead_g with struct ↵Malcolm Priestley
vnt_tx_datahead_g Replace members b, a, wDuration_b, wDuration_a, wTimeStampOff_b and wTimeStampOff_a with b, a, duration_b, duration_a, time_stamp_off_b and time_stamp_off_a Using __le16 endian type for unsigned short. Creating the new structure in rxtx.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: rxtx.c create function to return __le16 wTimeStampOffMalcolm Priestley
wTimeStampOff always needs to be endian corrected. Create vnt_time_stamp_off to return this value. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: s_vGenerateTxParameter removed nested pvRrvTime NULL checkMalcolm Priestley
Just do single NULL check on pvRrvTime and return. If pvRrvTime is NULL none of the if statements are valid. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: rxtx change s_uGetRTSCTSRsvTime to always return __le16Malcolm Priestley
s_uGetRTSCTSRsvTime always needs to return little endian __le16 Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: create vnt_rxtx_rsvtime_le16 to return s_uGetTxRsvTime ↵Malcolm Priestley
endian corrected. Replace s_uGetTxRsvTime where endian correction is needed. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: rxtx replace typedef struct tagSRrvTime_ab with struct ↵Malcolm Priestley
vnt_rrv_time_ab Replacing members wRTSTxRrvTime and wTxRrvTime with rts_rrv_time and rrv_time using __le16 type Moving structure to rxtx.h pvRrvTime is a void pointer Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: rxtx replace typedef struct tagSRrvTime_gCTS with struct ↵Malcolm Priestley
vnt_rrv_time_cts replacing members wCTSTxRrvTime_ba, wReserved, wTxRrvTime_b and wTxRrvTime_a with cts_rrv_time_ba, reserved, rrv_time_b and rrv_time_a; Creating the new structure in rxtx.h and Using __le16 where necessary pvRrvTime is a void pointer Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: rxtx replace typedef struct tagSRrvTime_gRTS with struct ↵Malcolm Priestley
vnt_rrv_time_rts Replacing members wRTSTxRrvTime_ba, wRTSTxRrvTime_aa, wRTSTxRrvTime_bb, wReserved, wTxRrvTime_b and wTxRrvTime_a with rts_rrv_time_ba, rts_rrv_time_aa, rts_rrv_time_bb, reserved, rrv_time_b and rrv_time_a Creating the new structure in rxtx.h and Using __le16 where necessary Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: rxtx create new structure vnt_tx_short_buf_head for ↵Malcolm Priestley
csBeacon_xmit This is a merger of PSTxDataHead_ab and PSTxShortBufHead of which typedef struct tagSTxShortBufHead is removed. This is formed as fifo_ctl, time_stamp, struct vnt_phy_field, duration and time_stamp_off. Replacing stuctures in csBeacon_xmit and doing endian correction where necessary. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: rxtx.h structure vnt_mic_hdr add IEEE80211_CCMP_PN_LEN macroMalcolm Priestley
ccmp_pn is the size of IEEE80211_CCMP_PN_LEN (6) Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: 80211mgr.h add ieee80211.h header and fix conflictsMalcolm Priestley
Fix conflict with WLAN_EID macros, by removing them. This allows the adding other definitions from the ieee80211 header. Eventually the 80211mgr.h header will be removed. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: dead code remove device_nics variableMalcolm Priestley
The module can not load more than once. Remove device_nics, MAX_UINTS and OPTION_DEFAULT Remove dead index variable from device_get_options Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: remove multiple instances of netdevice.Malcolm Priestley
netdevice can only be created once. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: remove multiple instances of driver loading.Malcolm Priestley
The driver can only load once from the instance provided by pci_dev. struct vnt_private next, prev and pDevice_Infos are removed. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: Remove BBvCalculateParameter and its data membersMalcolm Priestley
Remove data members bySignalField*, byServiceField*, wTransmitLength* from structures in desc.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: card.c change BBvCalculateParameter to vnt_get_phy_fieldMalcolm Priestley
Using vnt_get_phy_field means the values are not in the correct write order the lower word and the upper word need to be swapped over for an u32 write out. Rather create another data variable to manipulate this structure. Create a new union vnt_phy_field_swap with struct vnt_phy_field, the u16 word swap and the u32 write out. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30staging: vt6655: rxtx.c change BBvCalculateParameter to function ↵Malcolm Priestley
vnt_get_phy_field Removing wLen and pointing to correct member. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>