From 01db3d1ff43aeedeaf11c8bc9d09493ec00c8f4a Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Wed, 12 Mar 2025 11:31:57 +0300 Subject: platform/x86/amd/pmc: fix leak in probe() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Call pci_dev_put(rdev) before returning. Fixes: 6ad1b2dc0f2a ("platform/x86/amd/pmc: Use managed APIs for mutex") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/65e2fffb-a1cb-4297-b725-661d6b790a05@stanley.mountain Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen --- drivers/platform/x86/amd/pmc/pmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/amd/pmc/pmc.c b/drivers/platform/x86/amd/pmc/pmc.c index 84bc47009e5f..d789d6cab794 100644 --- a/drivers/platform/x86/amd/pmc/pmc.c +++ b/drivers/platform/x86/amd/pmc/pmc.c @@ -785,7 +785,7 @@ static int amd_pmc_probe(struct platform_device *pdev) err = devm_mutex_init(dev->dev, &dev->lock); if (err) - return err; + goto err_pci_dev_put; /* Get num of IP blocks within the SoC */ amd_pmc_get_ip_info(dev); -- cgit v1.2.3