From 04745f208c5b7de16fb35628b0003744b760b2cd Mon Sep 17 00:00:00 2001 From: Milan Broz Date: Sat, 21 Jul 2007 04:37:27 -0700 Subject: [PATCH] dm io: fix panic on large request Flush workqueue before releasing bioset and mopools in dm-crypt. There can be finished but not yet released request. Call chain causing oops: run workqueue dec_pending bio_endio(...); mempool_free(io, cc->io_pool); This usually happens when cryptsetup create temporary luks mapping in the beggining of crypt device activation. When dm-core calls destructor crypt_dtr, no new request are possible. Signed-off-by: Milan Broz Cc: Chuck Ebbert Cc: Patrick McHardy Acked-by: Alasdair G Kergon Cc: Christophe Saout Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman Signed-off-by: Willy Tarreau --- drivers/md/dm-crypt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c index b9ff4e368aad..6b50991623ef 100644 --- a/drivers/md/dm-crypt.c +++ b/drivers/md/dm-crypt.c @@ -917,6 +917,8 @@ static void crypt_dtr(struct dm_target *ti) { struct crypt_config *cc = (struct crypt_config *) ti->private; + flush_workqueue(_kcryptd_workqueue); + bioset_free(cc->bs); mempool_destroy(cc->page_pool); mempool_destroy(cc->io_pool); -- cgit v1.2.3