From f69d9be1947af12d634bf6a8da4fd44bdf58193d Mon Sep 17 00:00:00 2001 From: Varun Wadekar Date: Tue, 7 Jun 2011 19:27:52 +0530 Subject: crypto: tegra-aes: validate clk_get return values instead of checking for NULL, IS_ERR() should be used to check the validity of a clock handle Change-Id: Ic0ef30c64f4bd95995dcde048cd7630e2d75cd92 Signed-off-by: Varun Wadekar Reviewed-on: http://git-master/r/35619 Reviewed-by: Bharat Nihalani --- drivers/crypto/tegra-aes.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/tegra-aes.c b/drivers/crypto/tegra-aes.c index 3d1bf4f93d23..21461172171c 100644 --- a/drivers/crypto/tegra-aes.c +++ b/drivers/crypto/tegra-aes.c @@ -1134,29 +1134,29 @@ static int tegra_aes_probe(struct platform_device *pdev) dd->bsea.res_id = TEGRA_ARB_BSEA; dd->bsev.pclk = clk_get(dev, "bsev"); - if (!dd->bsev.pclk) { - dev_err(dev, "pclock intialization failed.\n"); + if (IS_ERR(dd->bsev.pclk)) { + dev_err(dev, "v: pclock intialization failed.\n"); err = -ENODEV; goto out; } dd->bsev.iclk = clk_get(dev, "vde"); - if (!dd->bsev.iclk) { - dev_err(dev, "iclock intialization failed.\n"); + if (IS_ERR(dd->bsev.iclk)) { + dev_err(dev, "v: iclock intialization failed.\n"); err = -ENODEV; goto out; } dd->bsea.pclk = clk_get(dev, "bsea"); - if (!dd->bsea.pclk) { - dev_err(dev, "pclock intialization failed.\n"); + if (IS_ERR(dd->bsea.pclk)) { + dev_err(dev, "a: pclock intialization failed.\n"); err = -ENODEV; goto out; } dd->bsea.iclk = clk_get(dev, "sclk"); - if (!dd->bsea.iclk) { - dev_err(dev, "iclock intialization failed.\n"); + if (IS_ERR(dd->bsea.iclk)) { + dev_err(dev, "a: iclock intialization failed.\n"); err = -ENODEV; goto out; } -- cgit v1.2.3