From cc5405b91411d58ea941926588fac95c2c5fce51 Mon Sep 17 00:00:00 2001 From: Marcel Ziswiler Date: Thu, 3 Mar 2022 15:50:23 +0100 Subject: arm64: dts: imx8mp-verdin: fix usb_1 extcon node Likely, the extcon-usb-gpio should not be definied within the i2c4 node but rather the SoC one. This fixes the following device tree compiler warning: arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi:581.28-586.4: Warning (i2c_bus_reg): /soc@0/bus@30800000/i2c@30a50000/usb_1_id: missing or empty reg property And fixes the following error on boot: [ 1.858518] i2c i2c-3: of_i2c: invalid reg on /soc@0/bus@30800000/ i2c@30a50000/usb_1_id [ 1.866544] i2c i2c-3: Failed to create I2C device for /soc@0/bus@ 30800000/i2c@30a50000/usb_1_id Fixes: bfe277fce128 ("arm64: dts: imx8mp-verdin: move USB_1 extcon node") Signed-off-by: Marcel Ziswiler --- arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'arch/arm64/boot/dts') diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi index ca6408f5734f..aeea6933b400 100755 --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi @@ -44,6 +44,14 @@ status = "disabled"; }; + /* USB_1 ID */ + extcon_usb_1_id: usb_1_id { + compatible = "linux,extcon-usb-gpio"; + id-gpio = <&gpio2 10 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usb_1_id>; + }; + gpio-keys { compatible = "gpio-keys"; pinctrl-names = "default"; @@ -576,14 +584,6 @@ reg = <0x57>; status = "disabled"; }; - - /* USB_1 ID */ - extcon_usb_1_id: usb_1_id { - compatible = "linux,extcon-usb-gpio"; - id-gpio = <&gpio2 10 GPIO_ACTIVE_HIGH>; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usb_1_id>; - }; }; &ldb { -- cgit v1.2.3