From 2a052074582d976bfa81e41a0337d8ae6dd1dc65 Mon Sep 17 00:00:00 2001 From: Naveen Kumar Chaudhary Date: Wed, 17 Jun 2026 07:58:20 +0530 Subject: kdb: unify CMD_BUFLEN definition into kdb_private.h CMD_BUFLEN was defined separately in kdb_io.c (256) and kdb_main.c (200), causing kdb_main.c to use the wrong size when formatting the prompt string into kdb_prompt_str (which is 256 bytes). Move CMD_BUFLEN (256) into kdb_private.h so all users share a single consistent definition, and remove the local definitions from both files. Fixes: 5d5314d6795f ("kdb: core for kgdb back end (1 of 2)") Signed-off-by: Naveen Kumar Chaudhary Link: https://lore.kernel.org/r/l6b6bomrw3bvkehlv73fyghk6loz6jpdwqk5c4nthnhl7j7kzk@4jjhfpzv5zon Signed-off-by: Daniel Thompson --- kernel/debug/kdb/kdb_io.c | 1 - kernel/debug/kdb/kdb_main.c | 6 ++---- kernel/debug/kdb/kdb_private.h | 3 ++- 3 files changed, 4 insertions(+), 6 deletions(-) (limited to 'kernel') diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c index c399f11740ef..f5b1b7d4c9c8 100644 --- a/kernel/debug/kdb/kdb_io.c +++ b/kernel/debug/kdb/kdb_io.c @@ -22,7 +22,6 @@ #include #include "kdb_private.h" -#define CMD_BUFLEN 256 char kdb_prompt_str[CMD_BUFLEN]; int kdb_trap_printk; diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index 31abaea5454e..40c332d2179d 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c @@ -784,8 +784,6 @@ static int kdb_exec_defcmd(int argc, const char **argv) /* Command history */ #define KDB_CMD_HISTORY_COUNT 32 -#define CMD_BUFLEN 200 /* kdb_printf: max printline - * size == 256 */ static unsigned int cmd_head, cmd_tail; static unsigned int cmdptr; static char cmd_hist[KDB_CMD_HISTORY_COUNT][CMD_BUFLEN]; @@ -1266,8 +1264,8 @@ static int kdb_local(kdb_reason_t reason, int error, struct pt_regs *regs, do_full_getstr: /* PROMPT can only be set if we have MEM_READ permission. */ - snprintf(kdb_prompt_str, CMD_BUFLEN, kdbgetenv("PROMPT"), - raw_smp_processor_id()); + snprintf(kdb_prompt_str, CMD_BUFLEN, + kdbgetenv("PROMPT"), raw_smp_processor_id()); /* * Fetch command from keyboard diff --git a/kernel/debug/kdb/kdb_private.h b/kernel/debug/kdb/kdb_private.h index 92a28b8ab604..722e8aa50724 100644 --- a/kernel/debug/kdb/kdb_private.h +++ b/kernel/debug/kdb/kdb_private.h @@ -225,7 +225,8 @@ extern void kdb_kbd_cleanup_state(void); #define kdb_kbd_cleanup_state() #endif /* ! CONFIG_KDB_KEYBOARD */ -extern char kdb_prompt_str[]; +#define CMD_BUFLEN 256 +extern char kdb_prompt_str[CMD_BUFLEN]; #define KDB_WORD_SIZE ((int)sizeof(unsigned long)) -- cgit v1.2.3