From 21ef40e66f6186898ea4240b83a0f1c7424953d0 Mon Sep 17 00:00:00 2001 From: "David S. Miller" Date: Wed, 25 Feb 2009 23:09:34 -0800 Subject: net: Kill skb_truesize_check(), it only catches false-positives. [ Upstream commit 92a0acce186cde8ead56c6915d9479773673ea1a ] A long time ago we had bugs, primarily in TCP, where we would modify skb->truesize (for TSO queue collapsing) in ways which would corrupt the socket memory accounting. skb_truesize_check() was added in order to try and catch this error more systematically. However this debugging check has morphed into a Frankenstein of sorts and these days it does nothing other than catch false-positives. Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/core/sock.c | 1 - 1 file changed, 1 deletion(-) (limited to 'net/core/sock.c') diff --git a/net/core/sock.c b/net/core/sock.c index d9fa31b991f6..93adc5c9db9b 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -1136,7 +1136,6 @@ void sock_rfree(struct sk_buff *skb) { struct sock *sk = skb->sk; - skb_truesize_check(skb); atomic_sub(skb->truesize, &sk->sk_rmem_alloc); sk_mem_uncharge(skb->sk, skb->truesize); } -- cgit v1.2.3