From 327d44754c54060baf9679ac073a21839912be16 Mon Sep 17 00:00:00 2001 From: Andreas Hindborg Date: Mon, 1 Jun 2026 12:17:05 +0200 Subject: rust: module_param: return value by copy from `value` For `Copy` parameter types it is more ergonomic to retrieve the parameter value by copy than through a shared reference. Change `ModuleParamAccess::value` to return `T` by copy when `T: Copy`, and rename the previous reference-returning accessor to `value_ref`. Update the in-tree caller in `rust_minimal`. Suggested-by: Alice Ryhl Signed-off-by: Andreas Hindborg Reviewed-by: Petr Pavlu Reviewed-by: Gary Guo Signed-off-by: Petr Pavlu --- samples/rust/rust_minimal.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'samples') diff --git a/samples/rust/rust_minimal.rs b/samples/rust/rust_minimal.rs index 8eb9583571d7..60d03df6cd80 100644 --- a/samples/rust/rust_minimal.rs +++ b/samples/rust/rust_minimal.rs @@ -28,7 +28,7 @@ impl kernel::Module for RustMinimal { pr_info!("Am I built-in? {}\n", !cfg!(MODULE)); pr_info!( "test_parameter: {}\n", - *module_parameters::test_parameter.value() + module_parameters::test_parameter.value() ); let mut numbers = KVec::new(); -- cgit v1.2.3 From da991304c9afc0f1567033ac743ce27dcc947652 Mon Sep 17 00:00:00 2001 From: Wenzhao Liao Date: Sat, 11 Apr 2026 09:02:54 -0400 Subject: rust: module_param: support bool parameters Add support for parsing boolean module parameters in the Rust module! macro. Currently, only integer types are supported by the `module_param!` macros. This patch implements the `ModuleParam` trait for `bool` by delegating the string parsing to the existing C implementation via `kstrtobool_bytes()`. It also wires up `PARAM_OPS_BOOL` so that the Rust parameter system correctly links to the C `param_ops_bool` structure. For demonstration and verification, a boolean parameter is added to `samples/rust/rust_minimal.rs`. Support for boolean parameters will initially be used by the Rust null block driver [1]. Link: https://lore.kernel.org/all/20260609-rnull-v6-19-rc5-send-v2-4-82c7404542e2@kernel.org/ [1] Assisted-by: Codex:GPT-5 Signed-off-by: Wenzhao Liao Tested-by: Andreas Hindborg Reviewed-by: Andreas Hindborg Link: https://lore.kernel.org/linux-modules/20260411130254.3510128-1-wenzhaoliao@ruc.edu.cn/ [ppavlu: add motivation to the commit message and rebase the patch] Signed-off-by: Petr Pavlu --- samples/rust/rust_minimal.rs | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'samples') diff --git a/samples/rust/rust_minimal.rs b/samples/rust/rust_minimal.rs index 60d03df6cd80..8c910d314dfa 100644 --- a/samples/rust/rust_minimal.rs +++ b/samples/rust/rust_minimal.rs @@ -15,6 +15,10 @@ module! { default: 1, description: "This parameter has a default of 1", }, + test_bool_parameter: bool { + default: false, + description: "This boolean parameter defaults to false", + }, }, } @@ -30,6 +34,10 @@ impl kernel::Module for RustMinimal { "test_parameter: {}\n", module_parameters::test_parameter.value() ); + pr_info!( + "test_bool_parameter: {}\n", + module_parameters::test_bool_parameter.value() + ); let mut numbers = KVec::new(); numbers.push(72, GFP_KERNEL)?; -- cgit v1.2.3