From 20a12565f1e2e8899ed046025a2da1dd6e6f4ed3 Mon Sep 17 00:00:00 2001 From: Daniel Baluta Date: Thu, 8 Nov 2018 14:40:50 +0200 Subject: MLK-20189-1: ASoC: fsl: dsp: Unlock proxy->lock on error path xf_cmd_recv will return with lock taken in two cases: * msg was received * waiting for msg was interrupted by a signal Make sure we unlock proxy->lock in both cases. This fixes Coverity issue: CID3335482. Reviewed-by: S.j. Wang Reviewed-by: Cosmin-Gabriel Samoila Signed-off-by: Daniel Baluta --- sound/soc/fsl/fsl_dsp.c | 1 + 1 file changed, 1 insertion(+) (limited to 'sound/soc/fsl/fsl_dsp.c') diff --git a/sound/soc/fsl/fsl_dsp.c b/sound/soc/fsl/fsl_dsp.c index 629947f65ca8..f303a73df282 100644 --- a/sound/soc/fsl/fsl_dsp.c +++ b/sound/soc/fsl/fsl_dsp.c @@ -231,6 +231,7 @@ static int fsl_dsp_ipc_msg_from_dsp(struct xf_client *client, m = xf_cmd_recv(&dsp_priv->proxy, &client->wait, &client->queue, 0); if (IS_ERR(m)) { + xf_unlock(&dsp_priv->proxy.lock); dev_err(dev, "receiving failed: %d", (int)PTR_ERR(m)); return PTR_ERR(m); } -- cgit v1.2.3