From 0985a94891c73740dea1e2697f9d598a4a7810ab Mon Sep 17 00:00:00 2001 From: Namhyung Kim Date: Thu, 16 Aug 2012 17:14:54 +0900 Subject: perf ui gtk: Add perf_gtk__show_helpline() for pr_* Use helpline for printing error/debug messages. The code resembles a TUI counter part and only print the first line of the message. Signed-off-by: Namhyung Kim Acked-by: Pekka Enberg Cc: Ingo Molnar Cc: Paul Mackerras Cc: Pekka Enberg Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1345104894-14205-5-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/setup.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'tools/perf/ui/setup.c') diff --git a/tools/perf/ui/setup.c b/tools/perf/ui/setup.c index 791fb15ce350..c7820e569660 100644 --- a/tools/perf/ui/setup.c +++ b/tools/perf/ui/setup.c @@ -1,7 +1,11 @@ +#include + #include "../cache.h" #include "../debug.h" +pthread_mutex_t ui__lock = PTHREAD_MUTEX_INITIALIZER; + void setup_browser(bool fallback_to_pager) { if (!isatty(1) || dump_trace) -- cgit v1.2.3 From ea251d51d2c7d7233790123227f787c477f567f5 Mon Sep 17 00:00:00 2001 From: Namhyung Kim Date: Mon, 3 Sep 2012 11:53:06 +0900 Subject: perf hists: Introduce perf_hpp for hist period printing Current hist print functions are messy because it has to consider many of command line options and the code doing that is scattered around to places. So when someone wants to add an option to manipulate the hist output it'd very easy to miss to update all of them in sync. And things getting worse as more options/features are added continuously. So I'd like to refactor them using hpp formats and move common code to ui/hist.c in order to make it easy to maintain and to add new features. Signed-off-by: Namhyung Kim Cc: Ingo Molnar Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1346640790-17197-2-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/setup.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'tools/perf/ui/setup.c') diff --git a/tools/perf/ui/setup.c b/tools/perf/ui/setup.c index c7820e569660..bd7d460f844c 100644 --- a/tools/perf/ui/setup.c +++ b/tools/perf/ui/setup.c @@ -1,8 +1,8 @@ #include -#include "../cache.h" -#include "../debug.h" - +#include "../util/cache.h" +#include "../util/debug.h" +#include "../util/hist.h" pthread_mutex_t ui__lock = PTHREAD_MUTEX_INITIALIZER; @@ -29,6 +29,8 @@ void setup_browser(bool fallback_to_pager) use_browser = 0; if (fallback_to_pager) setup_pager(); + + perf_hpp__init(false, false); break; } } -- cgit v1.2.3