u-boot-toradex.git/lib, branch master

acpi: fix initial RSDT and XSDT size

2026-05-11T18:04:43+00:00

When creating the RSDT and the XSDT table they contain no entries.
The table size therefore must equal the header size.

Without this change a NULL deference has been observed in
acpi_find_table() when running `ut dm` on sandbox64_defconfig
executed via `sudo ./u-boot -D`.

Fixes: 94ba15a3f13f ("x86: Move base tables to a writer function")
Fixes: 7e586f69070d ("acpi: Put table-setup code in its own function")
Fixes: ab5efd576c4e ("x86: acpi: Adjust order in acpi_table.c")
Fixes: 867bcb63e79f ("x86: Generate a valid ACPI table")
Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Simon Glass 

Update dm_test_acpi_ctx_and_base_tables() in test/dm/acpi.c to expect
sizeof(struct acpi_table_header) for the initial table length (instead
of sizeof(*rsdt) / sizeof(*xsdt)), and to compute the checksum over
header->length bytes rather than the full struct size:
Signed-off-by: Simon Glass

lib: fdtdec: validate bloblist FDT before consuming libfdt size

2026-05-08T21:49:27+00:00

Coverity Scan defects are observed in fdtdec_apply_bloblist_dtos(),
since the live FDT taken from the bloblist is passed to libfdt helpers
which consume header size/offset fields:
- fdt_open_into()
- fdt_pack()

Validate the bloblist FDT with fdt_check_full() before calling
fdt_open_into() and again after applying overlays before calling
fdt_pack(). This makes the libfdt consumers operate on a checked FDT
blob while keeping the existing flow unchanged.

Also normalize libfdt return codes from this path to errno values,
including the overlay callback path through bloblist_apply_blobs().

Fixes: b70cbbfbf94f ("fdtdec: apply DT overlays from bloblist")
Addresses-Coverity-ID: CID 645837: (TAINTED_SCALAR)
Signed-off-by: Raymond Mao 
Reviewed-by: Alexander Sverdlin

efi_mem_sort: use list_for_each_entry_safe instead

2026-05-05T14:29:08+00:00

Use list_for_each_entry_safe and comparisons against the current and
next efi_mem_desc. This reduces the computation required for merging
regions, prevents unnecessary additional iterations of the list, and
requires less temporary values.

Signed-off-by: Randolph Sapp 
Reviewed-by: Ilias Apalodimas 
Reviewed-by: Simon Glass

efi_selftest_memory: check for duplicates first

2026-05-05T14:29:08+00:00

Check for duplicate memory mappings before reporting any incorrect
attributes. Could be that second allocation has the correct type while
the first doesn't. Knowing there is a duplicate in this scenario is
more helpful than just reporting the first mismatch.

Signed-off-by: Randolph Sapp 
Reviewed-by: Ilias Apalodimas 
Reviewed-by: Simon Glass

efi_dt_fixup: use fdtdec_get_bool

2026-05-05T14:29:08+00:00

Use the more straightforward fdtdec_get_bool instead of fdt_getprop and
a return code check.

Signed-off-by: Randolph Sapp 
Reviewed-by: Ilias Apalodimas 
Reviewed-by: Anshul Dalal 
Reviewed-by: Heinrich Schuchardt 
Reviewed-by: Simon Glass

efi_loader: initialize variables in efi_dp_from_http()

2026-05-05T14:29:08+00:00

When using lwIP, efi_dp_from_http() may fail to initialize ip or mask.
Initialize the variables before the call.

Addresses-Coverity-ID: 645840 - Uninitialized variables (UNINIT)
Reviewed-by: Ilias Apalodimas 
Reviewed-by: Simon Glass 
Signed-off-by: Heinrich Schuchardt

fdt: check fdt_pack() return value in fdtdec_apply_bloblist_dtos()

2026-05-04T18:56:08+00:00

The fdt_pack() function can return an error code, but its return value
was not being checked. Add proper error handling to propagate any
failure.

Also fix typo in comment: "Shink" -> "Shrink".

Addresses-Coverity-ID: CID 645839: Error handling issues (CHECKED_RETURN)
Signed-off-by: Michal Simek 
Reviewed-by: Alexander Sverdlin 
Reviewed-by: Simon Glass 
Reviewed-by: Raymond Mao

efi_loader: centralize messaging for efi_init_obj_list

2026-05-01T08:30:03+00:00

If efi_init_obj_list() fails we cannot use the UEFI sub-system.

* Instead of having messages for this everywhere write an error message
  in efi_init_obj_list().
* Always use (ret != EFI_SUCCESS) when checking the return value of
  efi_init_obj_list().
* Remove the return code from the error message as it does not help
  users to understand which initialization went wrong.

Signed-off-by: Heinrich Schuchardt

efi_loader: correct efi_binary_run_dp() return value

2026-05-01T08:30:03+00:00

efi_binary_run_dp() is expected to return an efi_status_t value.

Reported-by: Simon Glass 
Fixes: 6422820ac3e5 ("efi_loader: split unrelated code from efi_bootmgr.c")
Reviewed-by: Simon Glass 
Reviewed-by: Ilias Apalodimas 
Signed-off-by: Heinrich Schuchardt

efi_loader: correct return value of efi_bootmgr_run()

2026-05-01T08:30:03+00:00

efi_bootmgr_run() is expected to return an efi_status_t value.

Reported-by: Simon Glass 
Fixes: 0bef4b0123f2 ("cmd: bootefi: move library interfaces under lib/efi_loader")
Reviewed-by: Simon Glass 
Reviewed-by: Ilias Apalodimas 
Signed-off-by: Heinrich Schuchardt