diff options
| author | Junhui Liu <junhui.liu@pigmoral.tech> | 2025-01-10 21:55:21 +0800 |
|---|---|---|
| committer | Mattijs Korpershoek <mkorpershoek@kernel.org> | 2025-06-02 09:57:25 +0200 |
| commit | 94a1f8fe47e26250dd5704b2c2187622522eca6b (patch) | |
| tree | 981e1a33a52b2df6db1dcebf7505347379ca7f2e /arch/arm/mach-stm32mp/cmd_stm32prog/cmd_stm32prog.c | |
| parent | 14f904130964f251e78349a2e370c5069f2af500 (diff) | |
usb: dwc2: Fix incorrect ULPI_UTMI_SEL bit setting
The ULPI_UTMI_SEL bit in the DWC2 driver was set incorrectly. According
to the datasheet [1], this bit should be set to 0 for UTMI interface and 1
for ULPI interface. The existing code had this logic reversed,
causing the interface selection to be incorrect.
This commit corrects the ULPI_UTMI_SEL bit setting to match the
datasheet's description. Referencing the kernel's code [2] also confirms
this fix.
[1] https://rockchip.fr/RK312X%20TRM/chapter-26-usb-otg-2-0.pdf#page=30
[2] https://github.com/torvalds/linux/blob/v6.13-rc3/drivers/usb/dwc2/core.c#L1106
Reviewed-by: Marek Vasut <marex@denx.de>
Tested-by: Peter Robinson <pbrobinson@gmail.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Signed-off-by: Junhui Liu <junhui.liu@pigmoral.tech>
Link: https://lore.kernel.org/r/20250110-dwc2-dev-v4-2-987f4fd6f8b2@pigmoral.tech
Signed-off-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
Diffstat (limited to 'arch/arm/mach-stm32mp/cmd_stm32prog/cmd_stm32prog.c')
0 files changed, 0 insertions, 0 deletions