diff options
author | Mike Frysinger <vapier@gentoo.org> | 2008-01-29 18:21:05 -0500 |
---|---|---|
committer | Wolfgang Denk <wd@denx.de> | 2008-04-13 13:53:45 -0700 |
commit | 1f1d88dd40815332df32982e739f2ddd2da6fe1a (patch) | |
tree | 84880cf65619d0b5d195804d73c1f7ba2739fe23 /common/cmd_elf.c | |
parent | e6dfed705efa44ebf00d21bb1588c6ccc8f3ad32 (diff) |
disable caches before booting an app for Blackfin apps
It isn't generally save to execute applications outside of U-Boot with caches
enabled due to the way the Blackfin processor handles caches (requires
software assistance). This patch disables caches before booting an ELF or
just booting raw code. The previous discussion on the patch was that we
wanted to use weaks instead, but that proved to not be feasible when multiple
symbols are involved, which puts us back at the ifdef solution. I've
minimized the ugliness by moving the setup step outside of the main function.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Diffstat (limited to 'common/cmd_elf.c')
-rw-r--r-- | common/cmd_elf.c | 22 |
1 files changed, 16 insertions, 6 deletions
diff --git a/common/cmd_elf.c b/common/cmd_elf.c index 2eb74531560..4683554040c 100644 --- a/common/cmd_elf.c +++ b/common/cmd_elf.c @@ -27,6 +27,21 @@ DECLARE_GLOBAL_DATA_PTR; #define MAX(a,b) ((a) > (b) ? (a) : (b)) #endif +static inline void bootelf_setup(int argc, char *argv[]) +{ + /* + * QNX images require the data cache is disabled. + * Data cache is already flushed, so just turn it off. + */ + if (dcache_status ()) + dcache_disable (); + +#ifdef CONFIG_BLACKFIN + if (icache_status ()) + icache_disable (); +#endif +} + int valid_elf_image (unsigned long addr); unsigned long load_elf_image (unsigned long addr); @@ -53,12 +68,7 @@ int do_bootelf (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) printf ("## Starting application at 0x%08lx ...\n", addr); - /* - * QNX images require the data cache is disabled. - * Data cache is already flushed, so just turn it off. - */ - if (dcache_status ()) - dcache_disable (); + bootelf_setup(argc, argv); /* * pass address parameter as argv[0] (aka command name), |