summaryrefslogtreecommitdiff
path: root/dts
diff options
context:
space:
mode:
authorStephen Warren <swarren@nvidia.com>2012-06-08 12:28:17 +0000
committerWolfgang Denk <wd@denx.de>2012-07-09 09:05:24 +0200
commit58e22f8a15adec39d24d060180d76a4cbe86a04b (patch)
tree5159beefe7c3df73d139d8073a89d30ad3e80b52 /dts
parentb8032734ee94f4031c71aa40f100e9ef181ea0ef (diff)
fdt: send all dtc output to stderr
Commit 896bbb5 "fdt: avoid bad MAKEALL status" added logic to capture the result code from dtc by echoing $? to stdout and capturing it using $(). However, dtc emits some diagnostics to stderr and some to stdout. The diagnostics send to stdout ended up getting captured via $() rather than being echo'd to the user. This caused those diagnostics to be passed to the exit command, which would then fail with the following cryptic error message: /bin/sh: line 1: exit: too many arguments Solve this by redirecting all dtc output to stderr so that $() does not capture it. This allows the user to see the actual error message from dtc. Cc: Wolfgang Denk <wd@denx.de> Cc: Simon Glass <sjg@chromium.org> Cc: albert.u.boot@aribaud.net Cc: Tom Warren <twarren@nvidia.com> Signed-off-by: Stephen Warren <swarren@nvidia.com> Acked-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'dts')
-rw-r--r--dts/Makefile2
1 files changed, 1 insertions, 1 deletions
diff --git a/dts/Makefile b/dts/Makefile
index 914e479fb2a..402dfe1dced 100644
--- a/dts/Makefile
+++ b/dts/Makefile
@@ -51,7 +51,7 @@ $(DT_BIN): $(TOPDIR)/board/$(VENDOR)/dts/$(DEVICE_TREE).dts
{ { $(DTC) -R 4 -p 0x1000 -O dtb -o ${DT_BIN} - 2>&1 ; \
echo $$? >&3 ; } | \
grep -v '^DTC: dts->dtb on file' ; \
- } 3>&1 ) ; \
+ } 3>&1 1>&2 ) ; \
exit $$rc
process_lds = \