summaryrefslogtreecommitdiff
path: root/lib/string.c
diff options
context:
space:
mode:
authorBin Meng <bmeng.cn@gmail.com>2023-07-31 14:01:05 +0800
committerBin Meng <bmeng.cn@gmail.com>2023-08-01 10:06:46 +0800
commitb5126f26d0c8d8560081b1f36ed7aee7f083104b (patch)
treebdc2f655e7108f135308317fb4599954a9064602 /lib/string.c
parent3dfa4115016de44410f7cc58fa5277ec39dcd4e1 (diff)
video: broadwell: Use mtrr_set_next_var() for graphics memory
At present this uses mtrr_add_request() & mtrr_commit() combination to program the MTRR for graphics memory. This usage has two major issues as below: - mtrr_commit() will re-initialize all MTRR registers from index 0, using the settings previously added by mtrr_add_request() and saved in gd->arch.mtrr_req[], which won't cause any issue but is unnecessary - The way such combination works is based on the assumption that U-Boot has full control with MTRR programming (e.g.: U-Boot without any blob that does all low-level initialization on its own, or using FSP2 which does not touch MTRR), but this is not the case with FSP. FSP programs some MTRRs during its execution but U-Boot does not have the settings saved in gd->arch.mtrr_req[] and when doing mtrr_commit() it will corrupt what was already programmed previously. Correct this to use mtrr_set_next_var() instead. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'lib/string.c')
0 files changed, 0 insertions, 0 deletions